List of commits:
Subject Hash Author Date (UTC)
fix(clearcasting): Improve subset buttons readabilitiy a86de677ad80a16372b76c67d1f8baa457f72faa Vladyslav Bondarenko 2021-11-04 22:23:53
fix(clearcasting)!: Export createSubset correctly e4a0fdb48ac3e3e63d7e763460fb6ca2d95a1f9f Vladyslav Bondarenko 2021-11-04 22:02:35
feat(choir): Render debuff type color for subset cb13282dcb4c42732eccf46821d9ff49e6f8bdff Vladyslav Bondarenko 2021-11-04 20:12:49
fix(choir)!: Subset auras update in combat 081493e96ee7c72371f8770d8bbdc9b108db53ac Vladyslav Bondarenko 2021-11-04 19:02:16
feat(choir)!: Add alternative section creation 1aac7826a961509021679db26b95071edba77ad8 Vladyslav Bondarenko 2021-11-04 17:36:05
feat(clearcasting): Add death knight indicators 5c42814210b355e6de601faaf8e173222995cfa6 Vladyslav Bondarenko 2021-10-30 12:23:43
feat!: Show spell tooltip on indicator mouseover dd69f46f1522f49ce942d8e0b3756c609471be7a Vladyslav Bondarenko 2021-10-13 01:12:08
feat!: Indicator grouping feature df7e0579a51388dba73bc5d92b3d04369bb0e426 Vladyslav Bondarenko 2021-10-13 00:17:28
feat!: Redo the core functionality 085af1bc403b3a9d2d4b99ec460d67889239fabd Vladyslav Bondarenko 2021-07-09 11:15:31
feat: Track additional auras 958e52f9808d64ebb816663d2aa22a4eb39a2068 Vladyslav Bondarenko 2021-01-22 20:28:13
fix!: No longer crash on unknown spell 65061085f0f55b75910c9ed4d8249b1e8e30f9ee Vladyslav Bondarenko 2020-12-11 17:31:16
fix: Render indicators properly on first login bf102cc749cc23d3769a82f10fe93a05afc5277f Vladyslav Bondarenko 2020-12-11 14:25:11
feat: Add Serendipity and Surge of Light indicators ba1d0f32a4b8f4f5d4e2730f0a4e409e23b52974 Vladyslav Bondarenko 2020-12-10 16:19:55
Initial commit 9b3df418e373218125fec12271084afebb11cfc2 Vladyslav Bondarenko 2020-12-04 10:27:24
Commit a86de677ad80a16372b76c67d1f8baa457f72faa - fix(clearcasting): Improve subset buttons readabilitiy
Reduce the amount of space subset aura indicators (button) take on the
screen, while still let them be easily readable to the user, hopefully.
Author: Vladyslav Bondarenko
Author date (UTC): 2021-11-04 22:23
Committer name: Vladyslav Bondarenko
Committer date (UTC): 2021-11-04 22:23
Parent(s): e4a0fdb48ac3e3e63d7e763460fb6ca2d95a1f9f
Signing key:
Tree: 81e48e12d000a87406518b898806311366c42de1
File Lines added Lines deleted
clearcasting.lua 22 8
File clearcasting.lua changed (mode: 100644) (index d9666e3..3e5d744)
... ... local function subsetEventProcessor(subsetFrame)
681 681 local category = auraTable[5] or 'none' local category = auraTable[5] or 'none'
682 682 assert (category ~= nil) assert (category ~= nil)
683 683 local red, green, blue = getAuraCategoryColor(category) local red, green, blue = getAuraCategoryColor(category)
684 local alpha = 0.6
685 background:SetTexture(red, green, blue, alpha)
684 background:SetTexture(red, green, blue)
686 685
687 686 local casterDesignation = auraTable[8] local casterDesignation = auraTable[8]
688 687 if 'player' == casterDesignation then if 'player' == casterDesignation then
 
... ... local function createSubsetButtonArtwork(subsetButton)
753 752
754 753 local buttonWidth = subsetButton:GetWidth() local buttonWidth = subsetButton:GetWidth()
755 754 local buttonHeight = subsetButton:GetHeight() local buttonHeight = subsetButton:GetHeight()
755 local padding = 2
756
757 local marginBottom = math.max(buttonWidth, buttonHeight) - math.min(buttonWidth, buttonHeight) + padding
756 758
757 local marginBottom = math.max(buttonWidth, buttonHeight) - math.min(buttonWidth, buttonHeight)
758 759 local artwork = subsetButton:CreateTexture(subsetButton:GetName() .. 'Artwork', 'ARTWORK') local artwork = subsetButton:CreateTexture(subsetButton:GetName() .. 'Artwork', 'ARTWORK')
759 artwork:SetPoint('TOPLEFT', 0, 0)
760 artwork:SetPoint('TOPRIGHT', 0, 0)
761 artwork:SetPoint('BOTTOMLEFT', 0, marginBottom)
762 artwork:SetPoint('BOTTOMRIGHT', 0, marginBottom)
760 artwork:SetPoint('TOPLEFT', padding, -padding)
761 artwork:SetPoint('TOPRIGHT', -padding, -padding)
762 artwork:SetPoint('BOTTOMLEFT', padding, marginBottom)
763 artwork:SetPoint('BOTTOMRIGHT', padding, marginBottom)
763 764 artwork:SetTexture("Interface\\Icons\\spell_nature_wispsplode") artwork:SetTexture("Interface\\Icons\\spell_nature_wispsplode")
765 local texMargin = 1.0 / 8.0
766 --artwork:SetTexCoord(0, 0.5, 0.5, 1) -- bottom left
767 --artwork:SetTexCoord(0.5, 0.0, 0.5, 1) -- bottom right
768 --artwork:SetTexCoord(0.1, 0.9, 0.1, 0.9) -- bottom right
769 artwork:SetTexCoord(texMargin, 1 - texMargin, texMargin, 1 - texMargin)
764 770
765 771 return artwork return artwork
766 772 end end
 
... ... end
768 774 local function createSubsetButtonBackground(subsetButton) local function createSubsetButtonBackground(subsetButton)
769 775 assert (subsetButton ~= nil) assert (subsetButton ~= nil)
770 776
777 local buttonWidth = subsetButton:GetWidth()
778 local buttonHeight = subsetButton:GetHeight()
779
780 local marginBottom = math.max(buttonWidth, buttonHeight) - math.min(buttonWidth, buttonHeight)
781
771 782 local background = subsetButton:CreateTexture(subsetButton:GetName() .. 'Background', 'BACKGROUND') local background = subsetButton:CreateTexture(subsetButton:GetName() .. 'Background', 'BACKGROUND')
772 background:SetAllPoints()
783 background:SetPoint('TOPLEFT', 0, 0)
784 background:SetPoint('TOPRIGHT', 0, 0)
785 background:SetPoint('BOTTOMLEFT', 0, marginBottom)
786 background:SetPoint('BOTTOMRIGHT', 0, marginBottom)
773 787 background:SetTexture(getAuraCategoryColor('none')) background:SetTexture(getAuraCategoryColor('none'))
774 788
775 789 return background return background
Hints:
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://rocketgit.com/user/vrtc/clearcasting

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@ssh.rocketgit.com/user/vrtc/clearcasting

Clone this repository using git:
git clone git://git.rocketgit.com/user/vrtc/clearcasting

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a merge request:
... clone the repository ...
... make some changes and some commits ...
git push origin main