File TODO changed (mode: 100644) (index 09a528c..aabb582) |
1 |
1 |
== Where I stopped last time == |
== Where I stopped last time == |
|
2 |
|
[ ] ssh key checked is install 0700 and owner root. It must be allowed to |
|
3 |
|
be run by rocketgit user! Spec? Makefile? |
|
4 |
|
[ ] totp: when trying to validate a token, if the token is wrong, the message |
|
5 |
|
is wrong ("you are not enrolled"). Is is a mess in totp_sc_verify |
|
6 |
|
because the error is set globally. We should pass it in return, |
|
7 |
|
not globally, everywhere is possible. |
|
8 |
|
[ ] We should check if the request was a POST and not a GET! Else, CSRF! |
|
9 |
|
[ ] PagerDuty, Splunk integration. |
|
10 |
|
[ ] Add "Only AGPL and no CLA!" where needed. |
|
11 |
|
[ ] comparison: "2fa for ssh". |
|
12 |
|
[ ] When generating html diff, use a sha1(file_name) to not inject XSS and |
|
13 |
|
for html to look nice. |
|
14 |
|
[ ] git_log_simple returns an array of commits, with a 'vars' section and |
|
15 |
|
a 'files' section. When calling git_log, we also need to pass also the |
|
16 |
|
from/to extracted from 'simple' output. Think about someone pushing changes |
|
17 |
|
betwen 'simple' and 'full'! |
|
18 |
|
[ ] We have some invalid numstat in the logs! |
|
19 |
|
[ ] We have lines_add/del. Why we need also 'changes' field (git.inc.php)?! |
|
20 |
|
[ ] 'git log --patch' for submodules probably is not working right. |
|
21 |
|
[ ] Allow users to change the value of 'diff.context'. |
|
22 |
|
[ ] rg_git_diff2array is called with already mangled file names (\xxx\xxx...) |
|
23 |
|
Check why they are not "correct". |
|
24 |
|
[ ] Document 2fa for http, now that is working. |
2 |
25 |
[ ] Replace all 'who_nice' open coded stuff with rg_user_nice. |
[ ] Replace all 'who_nice' open coded stuff with rg_user_nice. |
3 |
26 |
[ ] ldap: What should happen when we update plan_id. |
[ ] ldap: What should happen when we update plan_id. |
4 |
27 |
What about other fields? |
What about other fields? |
|
13 |
36 |
[ ] 2fa: test pushing by http(by_http.php)/ssh(?). |
[ ] 2fa: test pushing by http(by_http.php)/ssh(?). |
14 |
37 |
[ ] Compare: mouse over is not working on touch-screens! |
[ ] Compare: mouse over is not working on touch-screens! |
15 |
38 |
[ ] Aug 18 15:10:04 rg2 audit[29395]: AVC avc: denied { map } for pid=29395 comm="git" path="/var/lib/rocketgit/repos/by_id/00/00/00/7B/0000007B/repos/by_id/125.git/objects/pack/pack-dbb7e352e05eec6b15b74679d813897b29fa0b62.idx" dev="dm-0" ino=133117 scontext=system_u:system_r:httpd_t:s0 tcontext=unconfined_u:object_r:rocketgit_var_t:s0 tclass=file permissive=1 |
[ ] Aug 18 15:10:04 rg2 audit[29395]: AVC avc: denied { map } for pid=29395 comm="git" path="/var/lib/rocketgit/repos/by_id/00/00/00/7B/0000007B/repos/by_id/125.git/objects/pack/pack-dbb7e352e05eec6b15b74679d813897b29fa0b62.idx" dev="dm-0" ino=133117 scontext=system_u:system_r:httpd_t:s0 tcontext=unconfined_u:object_r:rocketgit_var_t:s0 tclass=file permissive=1 |
16 |
|
[ ] When pushing/fetching, log also the debug id. |
|
17 |
39 |
[ ] Truncate big descriptions. |
[ ] Truncate big descriptions. |
18 |
40 |
[ ] report how many repos/users/etc. were removed. |
[ ] report how many repos/users/etc. were removed. |
19 |
41 |
[ ] Investigate WWW-Authenticate HTTP header. |
[ ] Investigate WWW-Authenticate HTTP header. |
|
98 |
120 |
[ ] |
[ ] |
99 |
121 |
|
|
100 |
122 |
== BEFORE NEXT RELEASE == |
== BEFORE NEXT RELEASE == |
|
123 |
|
[ ] When trying to clone by http, and I am enrolled in 2fa, I get an error: |
|
124 |
|
Error: non existing repo or you are not allowed to push! |
|
125 |
|
Which should not say anything about "push"! |
|
126 |
|
Fix is in developemnt. Just need to deploy. And notify nljelfs. |
|
127 |
|
[ ] After enrolling in 2fa, we need to clear the fields! |
|
128 |
|
[ ] Personalize welcome e-mail. |
|
129 |
|
[ ] Allow (regex) only some domains/IPs to join the system. |
|
130 |
|
[ ] Warn web users if they use TLS < 1.2. |
101 |
131 |
[ ] Sec: must read https://www.usenix.org/system/files/conference/usenixsecurity15/sec15-paper-zheng-updated.pdf |
[ ] Sec: must read https://www.usenix.org/system/files/conference/usenixsecurity15/sec15-paper-zheng-updated.pdf |
102 |
132 |
[ ] Allow authentication by certificate. |
[ ] Allow authentication by certificate. |
103 |
133 |
[ ] passwords: we need multiple round of hashing. |
[ ] passwords: we need multiple round of hashing. |
|
... |
... |
But, we have a problem with the expiration time! |
1874 |
1904 |
[ ] Secure transport X in configuratia de apache. Sau in index.php? |
[ ] Secure transport X in configuratia de apache. Sau in index.php? |
1875 |
1905 |
|
|
1876 |
1906 |
== BEFORE NEXT-NEXT RELEASE == |
== BEFORE NEXT-NEXT RELEASE == |
1877 |
|
[ ] mcr@sandelman.ca: It would be nice if github could be told to reject |
|
|
1907 |
|
[ ] Matrix.org support: |
|
1908 |
|
https://gist.github.com/RickCogley/69f430d4418ae5498e8febab44d241c9 |
|
1909 |
|
[ ] mcr at sandelman dot ca: It would be nice if github could be told to reject |
1878 |
1910 |
and/or mark files that have whitespace errors. |
and/or mark files that have whitespace errors. |
1879 |
1911 |
[ ] Transform user/bug/* into high level functions. |
[ ] Transform user/bug/* into high level functions. |
1880 |
1912 |
[ ] Maybe, when user is not logged in, on the "Repositories" main menu |
[ ] Maybe, when user is not logged in, on the "Repositories" main menu |
|
... |
... |
them after processing is done. |
2399 |
2431 |
[ ] If a user has no push access and creates merge request, but the owner pushed |
[ ] If a user has no push access and creates merge request, but the owner pushed |
2400 |
2432 |
nothing, ssh cloning gives errors about HEAD not found. |
nothing, ssh cloning gives errors about HEAD not found. |
2401 |
2433 |
[ ] Add a "Report a bug on this page" - we already have the log_id! |
[ ] Add a "Report a bug on this page" - we already have the log_id! |
|
2434 |
|
[ ] Allow a way to authenticate (only) with certificates. We need to specify |
|
2435 |
|
a CA to be able to validate them. |
2402 |
2436 |
|
|
2403 |
2437 |
|
|
2404 |
2438 |
== Graphics == |
== Graphics == |