List of commits:
Subject Hash Author Date (UTC)
bug: search: fixed the override of some global variables 82e251ea883e50b8d1476530e0268fd5770fbf41 Catalin(ux) M. BOIE 2020-06-10 21:29:03
If a repo is non-existent, we should not try to use the id bcb08f74e21556aa750920335ebec2f965e72f36 Catalin(ux) M. BOIE 2020-06-10 08:05:43
If no activity, average elap is not computed correctly a7d4f0042c912d29f7943e0446820a477f42d6f7 Catalin(ux) M. BOIE 2020-06-09 07:03:21
When a user is requesting an e-mail confirmation operation, ignore if the e-mail was confirmed 62c387ed431d0c46d16e534cc1c954557ee389f7 Catalin(ux) M. BOIE 2020-06-08 06:42:22
Reverse test messed the creation of partition tables; more debugging d820816c2624549e0b0e1634523717cda0b7ba66 Catalin(ux) M. BOIE 2020-06-05 17:33:08
We need to prepare the partition tables before some inserts 07a12d1c79104b4707a9d43463fa9c11a4697293 Catalin(ux) M. BOIE 2020-06-05 15:55:43
.spec updates 5fe0aca1b4a3bfd8c1c8db95409faf512ad09b43 Catalin(ux) M. BOIE 2020-06-04 22:03:57
Switch to Podman (because of Fedora 32) and fix the worker service in the spec file 05b3866cd09b0aa8367d3b5755f45ea7274658de Catalin(ux) M. BOIE 2020-06-04 15:50:41
Added sample configuration for workers df36ccd20e40987a4ca2355062ee1312aa2ee3a2 Catalin(ux) M. BOIE 2020-06-04 15:14:52
Avoid complains from install for systemd daemon-reload 683a92542cc0608293ceefc111a05e1eb328a2d8 Catalin(ux) M. BOIE 2020-06-04 15:09:57
Small stuff e64a838d032e54587ab3110ab8bb04a0cde78231 Catalin(ux) M. BOIE 2020-06-04 14:49:56
Lots of changes b8164d9e1e263eb4db75e32430f0753b63d0028e Catalin(ux) M. BOIE 2020-06-04 07:14:35
Lots of small fixes and functional tests ad2c8f4ce214896cb5984031dbd916467878ccfd Catalin(ux) M. BOIE 2020-05-16 09:30:47
Lots of things, mostly worker fixes 8768227306ef89ecc51d392cf986e75a7044dde4 Catalin(ux) M. BOIE 2020-04-10 15:27:11
Added functional test for HTTP 304 code 93205ec14d1073c434360abf7ea525a75407b1ab Catalin(ux) M. BOIE 2020-04-02 14:05:49
Lots of changes all over the place 3ddbd9e686f514eed1e715d7702a910ca3f8b22c Catalin(ux) M. BOIE 2020-04-01 07:17:57
More tests updates d5d45ace725f6ab336998a328136a2f7f9474df1 Catalin(ux) M. BOIE 2020-04-01 05:30:54
Lots of tests updates 183c4af52e56ae4e4fd74a35e2b17ac79952aec6 Catalin(ux) M. BOIE 2020-03-20 16:10:33
Improved a little bit the mail reporting for admin 576f96d554b1e273391ac54404bf5f885325e5e8 Catalin(ux) M. BOIE 2020-03-03 19:25:17
Worker and builder big changes 90f596e4fd8fa291b1da831bce609b486c7a5875 Catalin(ux) M. BOIE 2020-01-06 13:31:20
Commit 82e251ea883e50b8d1476530e0268fd5770fbf41 - bug: search: fixed the override of some global variables
Author: Catalin(ux) M. BOIE
Author date (UTC): 2020-06-10 21:29
Committer name: Catalin(ux) M. BOIE
Committer date (UTC): 2020-06-10 21:29
Parent(s): bcb08f74e21556aa750920335ebec2f965e72f36
Signer:
Signing key:
Signing status: N
Tree: 9c50ae2f773864518749fbd866e9d1b0d1e050a3
File Lines added Lines deleted
inc/user/repo/bug/search/search.php 18 18
root/themes/default/repo/bug/search/search.html 15 13
tests/http_bug.php 33 3
File inc/user/repo/bug/search/search.php changed (mode: 100644) (index 22c08b9..ceb8047)
... ... if ($rg['doit'] == 0) {
22 22 $_x['global'] = "off"; $_x['global'] = "off";
23 23 $_x['name'] = ""; $_x['name'] = "";
24 24 } else { } else {
25 $_x['reported_by'] = rg_var_str("reported_by");
26 $_x['assigned_to'] = rg_var_str("assigned_to");
27 $_x['state'] = rg_var_uint("state");
28 $_x['order_by'] = rg_var_str("order_by");
29 $_x['include'] = rg_var_str("include");
30 $_x['exclude'] = rg_var_str("exclude");
31 $_x['start'] = rg_var_str("start");
32 $_x['end'] = rg_var_str("end");
33 $_x['title_string'] = rg_var_str("title_string");
34 $_x['body_string'] = rg_var_str("body_string");
35 $_x['bugs_per_page'] = rg_var_uint("bugs_per_page");
36 $_x['for_all_users'] = rg_var_str("for_all_users");
37 $_x['global'] = rg_var_str("global");
38 $_x['name'] = rg_var_str("name");
25 $_x['reported_by'] = rg_var_str('bug_search::reported_by');
26 $_x['assigned_to'] = rg_var_str('bug_search::assigned_to');
27 $_x['state'] = rg_var_uint('bug_search::state');
28 $_x['order_by'] = rg_var_str('bug_search::order_by');
29 $_x['include'] = rg_var_str('bug_search::include');
30 $_x['exclude'] = rg_var_str('bug_search::exclude');
31 $_x['start'] = rg_var_str('bug_search::start');
32 $_x['end'] = rg_var_str('bug_search::end');
33 $_x['title_string'] = rg_var_str('bug_search::title_string');
34 $_x['body_string'] = rg_var_str('bug_search::body_string');
35 $_x['bugs_per_page'] = rg_var_uint('bug_search::bugs_per_page');
36 $_x['for_all_users'] = rg_var_str('bug_search::for_all_users');
37 $_x['global'] = rg_var_str('bug_search::global');
38 $_x['name'] = rg_var_str('bug_search::name');
39 39 $_x['standard'] = 0; $_x['standard'] = 0;
40 40
41 41 while (1) { while (1) {
 
... ... if ($rg['doit'] == 0) {
52 52 } }
53 53 } }
54 54
55 $rg = array_merge($rg, $_x);
55 $rg = rg_array_merge($rg, 'bug_search', $_x);
56 56 $rg['HTML:errmsg'] = rg_template_errmsg($errmsg); $rg['HTML:errmsg'] = rg_template_errmsg($errmsg);
57 57 $_exclude = array(); $_exclude = array();
58 $rg['HTML:state_select'] = rg_bug_state_select($_x['state'], $_exclude);
59 $_bug_search .= rg_template("repo/bug/search/search.html", $rg, TRUE /* xss */);
60 ?>
58 $rg['HTML:bug_search_state_select'] =
59 rg_bug_state_select($_x['state'], $_exclude);
60 $_bug_search .= rg_template('repo/bug/search/search.html', $rg, TRUE /*xss*/);
File root/themes/default/repo/bug/search/search.html changed (mode: 100644) (index c9c6eed..27971d8)
9 9
10 10 <p> <p>
11 11 <label for="reported_by">Reported by</label><br /> <label for="reported_by">Reported by</label><br />
12 <input type="text" name="reported_by" id="reported_by" value="@@reported_by@@" size="30" />
12 <input type="text" name="bug_search::reported_by" id="reported_by" value="@@bug_search::reported_by@@" size="30" />
13 13 </p> </p>
14 14
15 15 <p> <p>
16 16 <label for="assigned_to">Assigned to</label><br /> <label for="assigned_to">Assigned to</label><br />
17 <input type="text" name="assigned_to" id="assigned_to" value="@@assigned_to@@" size="30" />
17 <input type="text" name="bug_search::assigned_to" id="assigned_to" value="@@bug_search::assigned_to@@" size="30" />
18 18 </p> </p>
19 19
20 20 <p> <p>
21 21 <label for="state">State</label><br /> <label for="state">State</label><br />
22 @@state_select@@
22 @@bug_search_state_select@@
23 23 </p> </p>
24 24
25 <!--
25 26 <p> <p>
26 27 <label for="order_by">Order by</label><br /> <label for="order_by">Order by</label><br />
27 <input type="text" name="order_by" id="order_by" value="@@order_by@@" size="40" />
28 <input type="text" name="bug_search::order_by" id="order_by" value="@@bug_search::order_by@@" size="40" />
28 29 </p> </p>
30 -->
29 31
30 32 <p> <p>
31 33 <label for="start">Start date (yyyy-mm-dd)</label><br /> <label for="start">Start date (yyyy-mm-dd)</label><br />
32 <input type="text" name="start" id="start" value="@@start@@" size="10" />
34 <input type="text" name="bug_search::start" id="start" value="@@bug_search::start@@" size="10" />
33 35 </p> </p>
34 36
35 37 <p> <p>
36 38 <label for="end">End date (yyyy-mm-dd)</label><br /> <label for="end">End date (yyyy-mm-dd)</label><br />
37 <input type="text" name="end" id="end" value="@@end@@" size="10" />
39 <input type="text" name="bug_search::end" id="end" value="@@bug_search::end@@" size="10" />
38 40 </p> </p>
39 41
40 42 <p> <p>
41 43 <label for="title_string">Title contains</label><br /> <label for="title_string">Title contains</label><br />
42 <input type="text" name="title_string" id="title_string" value="@@title_string@@" size="40" />
44 <input type="text" name="bug_search::title_string" id="title_string" value="@@bug_search::title_string@@" size="40" />
43 45 </p> </p>
44 46
45 47 <p> <p>
46 48 <label for="body_string">Body contains</label><br /> <label for="body_string">Body contains</label><br />
47 <input type="text" name="body_string" id="body_string" value="@@body_string@@" size="40" />
49 <input type="text" name="bug_search::body_string" id="body_string" value="@@bug_search::body_string@@" size="40" />
48 50 </p> </p>
49 51
50 52 <p> <p>
51 53 <label for="bugs_per_page">Bugs per page</label><br /> <label for="bugs_per_page">Bugs per page</label><br />
52 <input type="text" name="bugs_per_page" id="bugs_per_page" value="@@bugs_per_page@@" size="10" />
54 <input type="text" name="bug_search::bugs_per_page" id="bugs_per_page" value="@@bug_search::bugs_per_page@@" size="10" />
53 55 </p> </p>
54 56
55 57 @@if(@@can_save@@ == 1){{ @@if(@@can_save@@ == 1){{
56 58 <p> <p>
57 <input type="checkbox" name="for_all_users" id="for_all_users"@@if(@@for_all_users@@ == on){{ checked="checked"}}{{}} />
59 <input type="checkbox" name="bug_search::for_all_users" id="for_all_users"@@if(@@bug_search::for_all_users@@ == on){{ checked="checked"}}{{}} />
58 60 <label for="for_all_users">Make this search public (available for other users)?</label> <label for="for_all_users">Make this search public (available for other users)?</label>
59 61 </p> </p>
60 62
61 63 <p> <p>
62 <input type="checkbox" name="global" id="global"@@if(@@global@@ == on){{ checked="checked"}}{{}} />
64 <input type="checkbox" name="bug_search::global" id="global"@@if(@@bug_search::global@@ == on){{ checked="checked"}}{{}} />
63 65 <label for="global">Make this search available also for other repos?</label> <label for="global">Make this search available also for other repos?</label>
64 66 </p> </p>
65 67
66 68 <p> <p>
67 69 <label for="name">Save search as</label><br /> <label for="name">Save search as</label><br />
68 <input type="text" name="name" id="name" value="@@name@@" size="40" />
70 <input type="text" name="bug_search::name" id="name" value="@@bug_search::name@@" size="40" />
69 71 </p> </p>
70 72 }}{{}} }}{{}}
71 73
72 74 <p> <p>
73 <input type="submit" name="button" value="Search" />
75 <input type="submit" name="bug_search::button" value="Search" />
74 76 </p> </p>
75 77 </form> </form>
76 78 </div> </div>
File tests/http_bug.php changed (mode: 100644) (index a4640d9..6e83c6b)
... ... rg_log_exit();
49 49 rg_log(''); rg_log('');
50 50 rg_log_enter("Posting bug form (token=$token)..."); rg_log_enter("Posting bug form (token=$token)...");
51 51 $labels = array('a/b', 'uu::bb', '<xss>'); sort($labels); $labels = array('a/b', 'uu::bb', '<xss>'); sort($labels);
52 $data = array('doit' => 1, 'edit' => 1, 'token' => $token,
52 $data = array(
53 'doit' => 1,
54 'edit' => 1,
55 'token' => $token,
53 56 'title' => 'Title1 space<xss>', 'title' => 'Title1 space<xss>',
54 57 'body' => 'aasasasassa<xss>', 'body' => 'aasasasassa<xss>',
55 58 'state' => 1, 'state' => 1,
 
... ... for ($i = 0; $i <= 1; $i++) {
282 285 } }
283 286 rg_log_exit(); rg_log_exit();
284 287
288
289 rg_log_enter('Search bugs: loading form...');
290 $url = '/user/' . $u1['username'] . '/' . $repo['name'] . '/bug/search';
291 $headers = array(); $data = array();
292 $r = do_req($test_url . $url, $data, $headers);
293 if ($r === FALSE) {
294 rg_log('Cannot load bug search page!');
295 exit(1);
296 }
297 rg_log_exit();
298
299
300 rg_log_enter('Search bugs: ad a search...');
301 $url = '/user/' . $u1['username'] . '/' . $repo['name'] . '/bug/search';
302 $headers = array(); $data = array('doit' => '1');
303 $r = do_req($test_url . $url, $data, $headers);
304 if ($r === FALSE) {
305 rg_log('Cannot do bug search!');
306 exit(1);
307 }
308 if (!strstr($r['body'], 'Title1 space&lt;xss&gt;')) {
309 rg_log_ml('r: ' . print_r($r, TRUE));
310 rg_log('Search did not returned our bug!');
311 exit(1);
312 }
313 rg_log_exit();
314
315
285 316 rg_prof_log(); rg_prof_log();
286 rg_log("OK!");
287 ?>
317 rg_log('OK!');
Hints:
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://rocketgit.com/user/catalinux/rocketgit

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@ssh.rocketgit.com/user/catalinux/rocketgit

Clone this repository using git:
git clone git://git.rocketgit.com/user/catalinux/rocketgit

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a merge request:
... clone the repository ...
... make some changes and some commits ...
git push origin main