List of commits:
Subject Hash Author Date (UTC)
feat: Hide native party frame be95fb0cc9435c4f4d30c419c06ad8b03946e12a Vladyslav Bondarenko 2022-05-27 05:36:29
feat: Shrink raid unit button size further b26214b3164b29dbd5f673421e14919b8239fc23 Vladyslav Bondarenko 2022-05-27 05:35:25
fix: Remove false assertion failures from bar code e774cdf9a57ea230e9c4610469785c9d0a1a9403 Vladyslav Bondarenko 2022-05-11 10:30:46
feat!: Add power bar 86e4270556a9570778f43abb662f1174ce4351e0 Vladyslav Bondarenko 2022-05-10 20:38:48
fix(choir)!: Update shortcuts without reloading UI 7f29a9404aa869805403f788703e048bcd538da0 Vladyslav Bondarenko 2022-01-26 23:13:05
feat(choir)!: Add spoiler pagination 1f1a418878887241a16374ca31592640a0c2941a Vladyslav Bondarenko 2022-01-08 13:30:53
fix(choir)!: Health bar update processor 7be81c650f45198678e8ca517afeb8413638579d Vladyslav Bondarenko 2022-01-08 10:14:54
feat(choir): Unit button contextual menu 981e9016b0c9a377219a13d2716d09de899efe60 Vladyslav Bondarenko 2022-01-08 10:06:50
fix(choir): Update range indicator correctly e2810d30fe62427920479057e1cc28f3ed45ff31 Vladyslav Bondarenko 2022-01-08 03:34:08
fix(choir): Raid frame and spoiler overlap e1a8da43270859a3c36b67f81357a935f0b6f2ef Vladyslav Bondarenko 2022-01-08 02:00:26
fix(choir): Update only existing units when necessary 82b7e0cfd4354263f27ea206f555e9771f2e8f8c Vladyslav Bondarenko 2021-12-31 07:45:00
feat(choir): Render unit threat situation dee7167e3a7e453425248a1062560f9bfd8b3bb4 Vladyslav Bondarenko 2021-12-28 01:39:09
fix(choir): Render dungeon role correctly for Cata 590a4abfd82659624688c4c1658de87693d3cd30 Vladyslav Bondarenko 2021-12-28 00:31:52
fix(choir): Show raid frame at player login 21a86d3840fb810c4ff4c67490aae7d5251c1bae Vladyslav Bondarenko 2021-11-24 06:07:10
feat(choir)!: Add interface options for raid frame ce677d3d0e7cfe05d1da5b159f52a0808db9ce9a Vladyslav Bondarenko 2021-11-24 06:05:37
feat(choir): Add conf spell shortcut default button c8e2c3493896f5ae589c516f742bbafd528140db Vladyslav Bondarenko 2021-11-24 02:28:19
feat(choir)!: Add configuration menu 12319ce873aecea4bfc0addec7c5ac5c1f225237 Vladyslav Bondarenko 2021-11-21 09:26:05
feat(choir): Add unit game tooltip 3ec490e489bb105f5096d5bb3e56814873deec3f Vladyslav Bondarenko 2021-11-20 09:34:12
fix(choir): Raid group frame arrange correctly b592f3f018ee521a821447ccf837aded703ad447 Vladyslav Bondarenko 2021-11-18 22:02:52
feat(choir): Render group role indicator for units 5f3a7c24d3f79035b8faa156355a2d017688134e Vladyslav Bondarenko 2021-11-18 22:02:27
Commit be95fb0cc9435c4f4d30c419c06ad8b03946e12a - feat: Hide native party frame
When Choir raid frames are enabled, hide native party and player
unit frames to save screen space. This is a runtime setting.
Author: Vladyslav Bondarenko
Author date (UTC): 2022-05-27 05:36
Committer name: Vladyslav Bondarenko
Committer date (UTC): 2022-06-03 11:42
Parent(s): b26214b3164b29dbd5f673421e14919b8239fc23
Signer:
Signing key: EFF9624877D25D02
Signing status: E
Tree: 84f11265c575ed8c1fdc938e922b7584382c340e
File Lines added Lines deleted
choir.lua 36 11
File choir.lua changed (mode: 100644) (index 5d01a48..c9a4576)
... ... local function raidFrameDisable(raidFrame)
1479 1479 raidFrame:UnregisterAllEvents() raidFrame:UnregisterAllEvents()
1480 1480 raidFrame:SetScript('OnEvent', nil) raidFrame:SetScript('OnEvent', nil)
1481 1481 raidFrame:Hide() raidFrame:Hide()
1482
1483 local partyFrameDisabler = _G['ChoirNativePartyFrameDisabler']
1484 if partyFrameDisabler then
1485 ChoirNativePartyFrameDisabler:Hide()
1486 ShowPartyFrame()
1487 PlayerFrame:Show()
1488 end
1482 1489 end end
1483 1490
1484 1491 local function raidFrameEnable(raidFrame) local function raidFrameEnable(raidFrame)
 
... ... local function raidFrameEnable(raidFrame)
1499 1506 raidFrame:Show() raidFrame:Show()
1500 1507
1501 1508 arrangeEveryRaidGroupFrame(raidFrame) arrangeEveryRaidGroupFrame(raidFrame)
1509
1510 local partyFrameDisabler = _G['ChoirNativePartyFrameDisabler']
1511 if partyFrameDisabler then
1512 ChoirNativePartyFrameDisabler:Show()
1513 HidePartyFrame()
1514 PlayerFrame:Hide()
1515 end
1502 1516 end end
1503 1517
1504 1518 local function raidFrameToggle(raidFrame) local function raidFrameToggle(raidFrame)
 
... ... local function initContextualMenu()
2181 2195 end end
2182 2196
2183 2197 local function initNativePartyFrameDisabler() local function initNativePartyFrameDisabler()
2184 --[[ FIXME Party frames still randomly show up ]]--
2198 local partyFrameDisabler = CreateFrame('FRAME', 'ChoirNativePartyFrameDisabler', nil, 'SecureHandlerShowHideTemplate')
2199
2200 --[[ Use secure handler feature to hide the native party frame.
2201 This way the runtime configuration also works in combat. ]]--
2202 --[[ In the script, "owner" variable refers to "ChoirNativePartyFrameDisabler" frame.
2203 "self" variable refers to either "PlayerFrame" native unit frame,
2204 or any of the party member frames.]]--
2205 local script = [=[
2206 if owner:IsShown() then
2207 self:Hide()
2208 end
2209 ]=]
2210
2185 2211 local i = 0 local i = 0
2186 2212 while (i < MAX_PARTY_MEMBERS) do while (i < MAX_PARTY_MEMBERS) do
2187 2213 i = i + 1 i = i + 1
2188 2214 local p = _G['PartyMemberFrame' .. i]; local p = _G['PartyMemberFrame' .. i];
2189 2215 assert (p ~= nil) assert (p ~= nil)
2190 p:HookScript('OnShow', function()
2191 if ChoirConfRaidFlag then
2192 HidePartyFrame()
2193 end
2194 end)
2195 end
2196 2216
2197 PlayerFrame:HookScript('OnShow', function(self)
2217 partyFrameDisabler:WrapScript(p, 'OnShow', script)
2198 2218 if ChoirConfRaidFlag then if ChoirConfRaidFlag then
2199 self:Hide()
2219 p:Hide()
2200 2220 end end
2201 end)
2221 end
2222 partyFrameDisabler:WrapScript(PlayerFrame, 'OnShow', script)
2202 2223
2203 2224 if ChoirConfRaidFlag then if ChoirConfRaidFlag then
2204 2225 PlayerFrame:Hide() PlayerFrame:Hide()
2205 HidePartyFrame()
2226 partyFrameDisabler:Show()
2227 else
2228 partyFrameDisabler:Hide()
2206 2229 end end
2207 2230 end end
2208 2231
 
... ... local function init(rootFrame)
2222 2245 local raidFrame = initRaidFrame(rootFrame, spoilerHolder, contextualMenu) local raidFrame = initRaidFrame(rootFrame, spoilerHolder, contextualMenu)
2223 2246 initConf(rootFrame, raidFrame) initConf(rootFrame, raidFrame)
2224 2247
2248 initNativePartyFrameDisabler(rootFrame)
2249
2225 2250 trace('init') trace('init')
2226 2251 end end
2227 2252
Hints:
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://rocketgit.com/user/vrtc/choir

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@ssh.rocketgit.com/user/vrtc/choir

Clone this repository using git:
git clone git://git.rocketgit.com/user/vrtc/choir

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a merge request:
... clone the repository ...
... make some changes and some commits ...
git push origin main