vrtc / chorus (public) (License: CC0) (since 2023-08-12) (hash sha1)
World of Warcraft add-on stub. The overall goal is to create a specialized raid frame.
List of commits:
Subject Hash Author Date (UTC)
fix: Filter out irrelevant events for status bars d11036a029bb51458c5bc592baf592463a05f11a Vladyslav Bondarenko 2023-08-25 09:02:07
feat: When group member out of range fade out e1b06d6c96ddceb3aa35ad5cc249671a5c1bf852 Vladyslav Bondarenko 2023-08-25 08:58:53
fix: Add unit tooltip 9b853289a7730a8783f02691c944492e0ef53f86 Vladyslav Bondarenko 2023-08-25 08:15:33
fix: Yet another health bar sanitization 979af69272eec06c45cb300132bc020a91a180c2 Vladyslav Bondarenko 2023-08-24 03:52:05
feat(build): Add stub RocketGit hook b1a0bb523fb570ee7cc73776bfbba1a6886e685f Vladyslav Bondarenko 2023-08-23 23:59:35
feat(build): Add 0.2-1 rockspec 92a2b006a47f1a242bbb08467c431362d64d6ef8 Vladyslav Bondarenko 2023-08-23 23:31:41
fix!: Use native mechanism of inheriting values 6a2ebf1aa52e4a300b4ad959670878b292140c4f Vladyslav Bondarenko 2023-08-23 23:05:39
fix: Typo in unit button template anchor 98027a2779639493c97c4259b61cb53d25709255 Vladyslav Bondarenko 2023-08-23 22:06:16
feat!: Add unit button flavours 21e61a0dbd629d25f458ce1a8dd370da31c6f991 Vladyslav Bondarenko 2023-08-23 21:17:33
fix: Shrink range frame height b73521b13c6a9e5d34b2d425e5d7e9ddcb04f81c Vladyslav Bondarenko 2023-08-23 21:15:28
feat: Hide status bar text on demand 307d97f5afee88e55c6799e4c4390ca8d6e98974 Vladyslav Bondarenko 2023-08-23 21:11:35
feat: Hide auras out of frame bounds cb9ca55fb9dc361500e8b4f4c84320eb7d01b744 Vladyslav Bondarenko 2023-08-23 20:53:30
fix: Add text shadow to unit names 2b7d56c701ad81825a838c9faa818632bf38bfb6 Vladyslav Bondarenko 2023-08-23 17:30:23
fix: Further sanitize health bar 3318dee15eac9b8205e287997800c080b0aaf12d Vladyslav Bondarenko 2023-08-23 14:56:00
feat!: Correct range indcator for all characters 8ef1a987ac4431ce90131c354d1a1775b653f3e3 Vladyslav Bondarenko 2023-08-22 15:05:35
fix: Improve health bar robustness 2be053184653a6cd282437f8190e9196af495d81 Vladyslav Bondarenko 2023-08-22 13:24:12
fix: Upgrade aura sorting a2132995674f81e0775def67b0f5786945b0bba3 Vladyslav Bondarenko 2023-08-22 13:21:37
feat: Add threat percentage for hostiles 590bc95167dfc0f22a135fe173182104b6f5b923 Vladyslav Bondarenko 2023-08-22 13:17:57
feat: Add threat for hostiles 22562481a0c9dfb297ebbe47da4aa19046cf6eeb Vladyslav Bondarenko 2023-08-21 22:28:50
fix(build): Add more luacheck definitions aac4bb444d894b5d565af3abe417cbafd4f966f5 Vladyslav Bondarenko 2023-08-21 18:09:50
Commit d11036a029bb51458c5bc592baf592463a05f11a - fix: Filter out irrelevant events for status bars
When health frame or power frame are triggered by an event, given the
event is not effectively relevant to the frame, such us updating health
for a unit that is not this frame's unit, quietly ignore the event
without running all the business logic. This is a sligiht performance
optimization. Additionally, it may prevent some breakage at runtime.
The developer still can't trace and reproduce some runtime issues with
the status bars.
Author: Vladyslav Bondarenko
Author date (UTC): 2023-08-25 09:02
Committer name: Vladyslav Bondarenko
Committer date (UTC): 2023-08-25 09:02
Parent(s): e1b06d6c96ddceb3aa35ad5cc249671a5c1bf852
Signer:
Signing key: EFF9624877D25D02
Signing status: E
Tree: e2f652771388b4acb6d92937b1d51252deb79194
File Lines added Lines deleted
src/ChorusProgressFrameTemplate.lua 33 2
File src/ChorusProgressFrameTemplate.lua changed (mode: 100644) (index 3079171..90cc906)
... ... local function applyHealthFrameColorUnitIsFriend(self, unitDesignation)
332 332 end end
333 333 end end
334 334
335 local function healthFrameEventProcessor(self)
335 local function healthFrameEventIsRelevant(self, eventCategory, ...)
336 local unitDesignation = SecureButton_GetUnit(self) or 'none'
337
338 local t = {
339 'UNIT_HEALTH',
340 'UNIT_POWER',
341 'UNIT_MANA',
342 'UNIT_ENERGY',
343 'UNIT_FOCUS',
344 'UNIT_RAGE',
345 'UNIT_RUNIC_POWER',
346 }
347 if tContains(t, eventCategory) then
348 return UnitIsUnit(unitDesignation, select(1, ...))
349 elseif 'PLAYER_TARGET_CHANGED' == eventCategory then
350 return UnitIsUnit('target', unitDesignation)
351 elseif 'PLAYER_FOCUS_CHANGED' == eventCategory then
352 return UnitIsUnit('focus', unitDesignation)
353 else
354 return true
355 end
356 end
357
358 local function healthFrameEventProcessor(self, eventCategory, ...)
336 359 validateProgressFrame(self) validateProgressFrame(self)
337 360
361 if not healthFrameEventIsRelevant(self, eventCategory, ...) then
362 return
363 end
364
338 365 local unitDesignation = SecureButton_GetUnit(self) or 'none' local unitDesignation = SecureButton_GetUnit(self) or 'none'
339 366
340 367 assert(unitDesignation ~= nil) assert(unitDesignation ~= nil)
 
... ... local function applyPowerFrameColor(self, powerTypeEnum)
405 432 end end
406 433 end end
407 434
408 local function powerFrameEventProcessor(self)
435 local function powerFrameEventProcessor(self, eventCategory, ...)
409 436 validateProgressFrame(self) validateProgressFrame(self)
410 437
438 if not healthFrameEventIsRelevant(self, eventCategory, ...) then
439 return
440 end
441
411 442 local unitDesignation = SecureButton_GetUnit(self) or 'none' local unitDesignation = SecureButton_GetUnit(self) or 'none'
412 443
413 444 assert(unitDesignation ~= nil) assert(unitDesignation ~= nil)
Hints:
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://rocketgit.com/user/vrtc/chorus

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@ssh.rocketgit.com/user/vrtc/chorus

Clone this repository using git:
git clone git://git.rocketgit.com/user/vrtc/chorus

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a merge request:
... clone the repository ...
... make some changes and some commits ...
git push origin main