vrtc / wowaddons (public) (License: GPLv3) (since 2020-12-04) (hash sha1)
No description available
Clone URLs: https://rocketgit.com/user/vrtc/wowaddons ssh://rocketgit@ssh.rocketgit.com/user/vrtc/wowaddons git://git.rocketgit.com/user/vrtc/wowaddons
beacon caramel choir choir-fix-improve_readability clearcasting crusade daybreak felhunter ironbar master reportafkbutton warbringer
List of commits:
Subject Hash Author Date (UTC)
fix(choir): Improve shortcut binding keys eb636de6e3f7bada9f0064ffe4db1db3f6433f6c Vladyslav Bondarenko 2021-10-31 18:55:10
fix(choir): Improve choirBindingKey attribute handling 6c5c2214cc1809e5e5e59cd3672da3cca3f2701f Vladyslav Bondarenko 2021-10-31 13:23:24
feat(choir)!: Add spell shortcut prototype d34f22a6983ffc41122acb40d22e3cb29c208a3c Vladyslav Bondarenko 2021-10-31 12:39:39
feat(choir)!: Add spell effects on unit d581df9fce342709267a3221dead4d00b9d14319 Vladyslav Bondarenko 2021-10-31 10:49:19
feat(choir)!: Close spoiler by pressing Esc 22d7370011ac45d25a410a3f569183d0cc9fb232 Vladyslav Bondarenko 2021-10-29 16:10:08
feat(choir)!: Range indicator 931a0510b562986ec76dc22f329f4af4ed723cdf Vladyslav Bondarenko 2021-10-29 10:40:46
fix(choir)!: Health bar in combat a6622578dd5a1b4e4babf699a4cf1e4eb6bb70d6 Vladyslav Bondarenko 2021-10-28 07:42:57
feat(choir)!: Decorate unit buttons 4dc5ed44a9519b275f4256cfe4281110b7a94c9a Vladyslav Bondarenko 2021-10-25 21:20:56
feat(choir)!: Copy action bar binding 70ce056ffda7f12d913ce9a42b128ea257bdd0dc Vladyslav Bondarenko 2021-10-23 23:34:56
feat!: Initial commit 45c4e781e5ff0a69f8b0bea3a869e2384c7ca454 Vladyslav Bondarenko 2021-10-23 06:03:14
Commit eb636de6e3f7bada9f0064ffe4db1db3f6433f6c - fix(choir): Improve shortcut binding keys
Author: Vladyslav Bondarenko
Author date (UTC): 2021-10-31 18:55
Committer name: Vladyslav Bondarenko
Committer date (UTC): 2021-10-31 18:55
Parent(s): 6c5c2214cc1809e5e5e59cd3672da3cca3f2701f
Signer:
Signing key:
Signing status: N
Tree: d67ea37e124c954c1ab09cc7e48595a30d2d04eb
File Lines added Lines deleted
choir.lua 36 16
File choir.lua changed (mode: 100644) (index a766c1e..a28775e)
... ... local function getButtonBindingKeyDefault(buttonNumber)
479 479 return key return key
480 480 end end
481 481
482 local function createUnitButtonSpellShortcut(unitButton, key)
483 assert (unitButton ~= nil)
482 local function getShortcutBindingKeySuggestion(buttonNumber, spellNumber)
483 assert (buttonNumber ~= nil)
484 assert (buttonNumber >= 1 and buttonNumber <= 5)
484 485
485 --[[ FIXME Add shortcuts for all classes and use cases ]]--
486 --[[createSpellShortcut(unitButton, unitButton:GetName() .. 'CureDiseaseButton', 'Cure Disease')]]--
487 --[[createSpellShortcut(unitButton, unitButton:GetName() .. 'LesserHealButton', 'Lesser Heal')]]--
486 assert (spellNumber ~= nil)
487 assert (spellNumber >= 1 and spellNumber <= 5)
488 488
489 local map = {
490 {'Q', 'ALT-Q', 'ALT-A', 'SHIFT-A', '1',},
491 {'W', 'ALT-W', 'ALT-S', 'SHIFT-S', '2',},
492 {'E', 'ALT-E', 'ALT-D', 'SHIFT-D', '3',},
493 {'R', 'ALT-R', 'ALT-F', 'SHIFT-F', '4',},
494 {'T', 'ALT-T', 'ALT-G', 'SHIFT-G', '5',},
495 }
489 496
490 local shortcut
497 local bindingList = map[buttonNumber]
491 498
492 key = key or unitButton:GetAttribute('choirBindingKey')
499 return bindingList[spellNumber]
500 end
493 501
494 shortcut = createSpellShortcut(unitButton, unitButton:GetName() .. 'AbolishDiseaseButton', 'Abolish Disease')
495 shortcut:SetAttribute('choirBindingKey', 'ALT-' .. key)
502 local function createUnitButtonSpellShortcut(unitButton, buttonNumber)
503 assert (unitButton ~= nil)
496 504
497 shortcut = createSpellShortcut(unitButton, unitButton:GetName() .. 'DispelMagicButton', 'Dispel Magic')
498 shortcut:SetAttribute('choirBindingKey', 'CTRL-' .. key)
505 --[[ FIXME Add shortcuts for all classes and use cases ]]--
506 local spellSet = {
507 'Dispel Magic',
508 'Abolish Disease',
509 'Renew',
510 'Power Word: Shield',
511 'Flash Heal',
512 }
499 513
500 shortcut = createSpellShortcut(unitButton, unitButton:GetName() .. 'FlashHealButton', 'Flash Heal')
501 shortcut:SetAttribute('choirBindingKey', 'SHIFT-' .. key)
514 local spellNumber = 0
515 while (spellNumber < #spellSet) do
516 spellNumber = spellNumber + 1
502 517
503 shortcut = createSpellShortcut(unitButton, unitButton:GetName() .. 'PowerWordShieldButton', 'Power Word: Shield')
504 shortcut:SetAttribute('choirBindingKey', 'CTRL-SHIFT-' .. key)
518 local n = unitButton:GetName() .. 'Shortcut' .. tostring(spellNumber)
519 local spellName = spellSet[spellNumber]
520 local b = createSpellShortcut(unitButton, n, spellName)
521
522 local key = getShortcutBindingKeySuggestion(buttonNumber, spellNumber)
523 b:SetAttribute('choirBindingKey', key)
524 end
505 525 end end
506 526
507 527 local function createGroup(rootFrame, groupNumber, unitTable) local function createGroup(rootFrame, groupNumber, unitTable)
 
... ... local function createGroup(rootFrame, groupNumber, unitTable)
558 578
559 579 _G['BINDING_NAME_CLICK ' .. b:GetName() .. ':LeftButton'] = 'Unit ' .. tostring(i) _G['BINDING_NAME_CLICK ' .. b:GetName() .. ':LeftButton'] = 'Unit ' .. tostring(i)
560 580
561 createUnitButtonSpellShortcut(b, key)
581 createUnitButtonSpellShortcut(b, i)
562 582 end end
563 583 spoiler:SetSize(marginLeft, 144) spoiler:SetSize(marginLeft, 144)
564 584 spoiler:SetPoint('CENTER', 0, 12 * 6) spoiler:SetPoint('CENTER', 0, 12 * 6)
Hints:
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://rocketgit.com/user/vrtc/wowaddons

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@ssh.rocketgit.com/user/vrtc/wowaddons

Clone this repository using git:
git clone git://git.rocketgit.com/user/vrtc/wowaddons

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a merge request:
... clone the repository ...
... make some changes and some commits ...
git push origin main