List of commits:
Subject Hash Author Date (UTC)
fix(clearcasting): Correct subset button order when first allocated f3b52da4b40e436e7dc5fc5bda8c4cdbf2c3f4a7 Vladyslav Bondarenko 2021-11-05 13:15:09
fix(clearcasting): Subset button clickable and updates slower ec4768e7b925e52126140788fe866070ee3796c3 Vladyslav Bondarenko 2021-11-05 13:05:13
fix(clearcasting): Improve subset buttons readabilitiy a86de677ad80a16372b76c67d1f8baa457f72faa Vladyslav Bondarenko 2021-11-04 22:23:53
fix(clearcasting)!: Export createSubset correctly e4a0fdb48ac3e3e63d7e763460fb6ca2d95a1f9f Vladyslav Bondarenko 2021-11-04 22:02:35
feat(choir): Render debuff type color for subset cb13282dcb4c42732eccf46821d9ff49e6f8bdff Vladyslav Bondarenko 2021-11-04 20:12:49
fix(choir)!: Subset auras update in combat 081493e96ee7c72371f8770d8bbdc9b108db53ac Vladyslav Bondarenko 2021-11-04 19:02:16
feat(choir)!: Add alternative section creation 1aac7826a961509021679db26b95071edba77ad8 Vladyslav Bondarenko 2021-11-04 17:36:05
feat(clearcasting): Add death knight indicators 5c42814210b355e6de601faaf8e173222995cfa6 Vladyslav Bondarenko 2021-10-30 12:23:43
feat!: Show spell tooltip on indicator mouseover dd69f46f1522f49ce942d8e0b3756c609471be7a Vladyslav Bondarenko 2021-10-13 01:12:08
feat!: Indicator grouping feature df7e0579a51388dba73bc5d92b3d04369bb0e426 Vladyslav Bondarenko 2021-10-13 00:17:28
feat!: Redo the core functionality 085af1bc403b3a9d2d4b99ec460d67889239fabd Vladyslav Bondarenko 2021-07-09 11:15:31
feat: Track additional auras 958e52f9808d64ebb816663d2aa22a4eb39a2068 Vladyslav Bondarenko 2021-01-22 20:28:13
fix!: No longer crash on unknown spell 65061085f0f55b75910c9ed4d8249b1e8e30f9ee Vladyslav Bondarenko 2020-12-11 17:31:16
fix: Render indicators properly on first login bf102cc749cc23d3769a82f10fe93a05afc5277f Vladyslav Bondarenko 2020-12-11 14:25:11
feat: Add Serendipity and Surge of Light indicators ba1d0f32a4b8f4f5d4e2730f0a4e409e23b52974 Vladyslav Bondarenko 2020-12-10 16:19:55
Initial commit 9b3df418e373218125fec12271084afebb11cfc2 Vladyslav Bondarenko 2020-12-04 10:27:24
Commit f3b52da4b40e436e7dc5fc5bda8c4cdbf2c3f4a7 - fix(clearcasting): Correct subset button order when first allocated
Previously the grid of subset buttons grew in an order that was not
intended due to a logical error. Fix it to allow the rows and columns
of buttons to appear as was originally intended and easily predictable.
Author: Vladyslav Bondarenko
Author date (UTC): 2021-11-05 13:15
Committer name: Vladyslav Bondarenko
Committer date (UTC): 2021-11-05 13:15
Parent(s): 618cc71e9cbdd3f86bb56c3458c3a794ff39aeab
Signer:
Signing key:
Signing status: N
Tree: 79c56391c7bc6b75a989610c6e10f71b5a4d3205
File Lines added Lines deleted
clearcasting.lua 3 3
File clearcasting.lua changed (mode: 100644) (index ee23f31..29b57fd)
... ... local function createSubset(parentFrame, frameDesignation, unitDesignation, filt
960 960 local nameFormat = subsetFrame:GetName() .. 'Button%03d' local nameFormat = subsetFrame:GetName() .. 'Button%03d'
961 961 local k = 0 local k = 0
962 962 local i = 0 local i = 0
963 while (i < columnQuantity) do
963 while (i < rowQuantity) do
964 964 i = i + 1 i = i + 1
965 965 local j = 0 local j = 0
966 while (j < rowQuantity) do
966 while (j < columnQuantity) do
967 967 j = j + 1 j = j + 1
968 968 k = k + 1 k = k + 1
969 969 local n = string.format(nameFormat, k) local n = string.format(nameFormat, k)
970 970 local emptySpellName = nil local emptySpellName = nil
971 971 local b = createSubsetButton(subsetFrame, n, unitDesignation, emptySpellName, filterDescriptor, local b = createSubsetButton(subsetFrame, n, unitDesignation, emptySpellName, filterDescriptor,
972 972 buttonWidth, buttonHeight) buttonWidth, buttonHeight)
973 b:SetPoint('BOTTOMLEFT', buttonWidth * (i - 1) + padding * i, buttonHeight * (j - 1) + padding * j)
973 b:SetPoint('BOTTOMLEFT', buttonWidth * (j - 1) + padding * j, buttonHeight * (i - 1) + padding * i)
974 974 end end
975 975 end end
976 976
Hints:
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://rocketgit.com/user/vrtc/wowaddons

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@ssh.rocketgit.com/user/vrtc/wowaddons

Clone this repository using git:
git clone git://git.rocketgit.com/user/vrtc/wowaddons

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a merge request:
... clone the repository ...
... make some changes and some commits ...
git push origin main