vrtc / wowaddons (public) (License: GPLv3) (since 2020-12-04) (hash sha1)
No description available
Clone URLs: https://rocketgit.com/user/vrtc/wowaddons ssh://rocketgit@ssh.rocketgit.com/user/vrtc/wowaddons git://git.rocketgit.com/user/vrtc/wowaddons
beacon caramel choir choir-fix-improve_readability clearcasting crusade daybreak felhunter ironbar master reportafkbutton warbringer
List of commits:
Subject Hash Author Date (UTC)
fix(choir)!: Obscure critical error 0f203b4d69f57240e97c66f1ab4510c6ac3e9276 Vladyslav Bondarenko 2021-11-11 12:52:02
feat(choir): Toggle button visibility given roster d193e7b5eb38cb3ac69d74eec1f96e00d90b6098 Vladyslav Bondarenko 2021-11-10 23:46:24
feat(choir)!: Add permanent raid frame 1839c35af4212c09038e972547d6b5893a9ce219 Vladyslav Bondarenko 2021-11-10 16:04:25
feat(choir)!: Employ Clearcasting subset feat 733c81538c3c965f07993fd7ddc482e724121b75 Vladyslav Bondarenko 2021-11-04 22:40:48
fix(choir): Improve shortcut binding keys eb636de6e3f7bada9f0064ffe4db1db3f6433f6c Vladyslav Bondarenko 2021-10-31 18:55:10
fix(choir): Improve choirBindingKey attribute handling 6c5c2214cc1809e5e5e59cd3672da3cca3f2701f Vladyslav Bondarenko 2021-10-31 13:23:24
feat(choir)!: Add spell shortcut prototype d34f22a6983ffc41122acb40d22e3cb29c208a3c Vladyslav Bondarenko 2021-10-31 12:39:39
feat(choir)!: Add spell effects on unit d581df9fce342709267a3221dead4d00b9d14319 Vladyslav Bondarenko 2021-10-31 10:49:19
feat(choir)!: Close spoiler by pressing Esc 22d7370011ac45d25a410a3f569183d0cc9fb232 Vladyslav Bondarenko 2021-10-29 16:10:08
feat(choir)!: Range indicator 931a0510b562986ec76dc22f329f4af4ed723cdf Vladyslav Bondarenko 2021-10-29 10:40:46
fix(choir)!: Health bar in combat a6622578dd5a1b4e4babf699a4cf1e4eb6bb70d6 Vladyslav Bondarenko 2021-10-28 07:42:57
feat(choir)!: Decorate unit buttons 4dc5ed44a9519b275f4256cfe4281110b7a94c9a Vladyslav Bondarenko 2021-10-25 21:20:56
feat(choir)!: Copy action bar binding 70ce056ffda7f12d913ce9a42b128ea257bdd0dc Vladyslav Bondarenko 2021-10-23 23:34:56
feat!: Initial commit 45c4e781e5ff0a69f8b0bea3a869e2384c7ca454 Vladyslav Bondarenko 2021-10-23 06:03:14
Commit 0f203b4d69f57240e97c66f1ab4510c6ac3e9276 - fix(choir)!: Obscure critical error
When raid frame and spoilers toggle visibility, sometimes the client
crashed and the frames did not render as expected. Apply a small
temporary fix to bypass the problem. The real cause is still unknown.
Author: Vladyslav Bondarenko
Author date (UTC): 2021-11-11 12:52
Committer name: Vladyslav Bondarenko
Committer date (UTC): 2021-11-11 12:52
Parent(s): cb0af119ae6107b6bdb07b93e4b21688195ca8a4
Signer:
Signing key:
Signing status: N
Tree: 7d21165fee49675f9d874bc7f2884363834834ec
File Lines added Lines deleted
choir.lua 40 36
File choir.lua changed (mode: 100644) (index 8ccf7b6..b49810f)
... ... local function createRaidGroupFrame(raidFrame, groupNumber, unitSetOverride)
726 726 return groupFrame return groupFrame
727 727 end end
728 728
729 local function createRaidFrameToggleHandler(raidFrame, spoilerHolder)
729 local function createRaidFrame(rootFrame, spoilerHolder)
730 assert (rootFrame ~= nil)
731 assert (spoilerHolder ~= nil)
732
733 local maxPartySize = 5
734 local maxSubgroupQuantity = 8
735
736 local buttonWidth = 48
737 local buttonHeight = 24 + 12 + 8
738 local padding = 2
739
740 local labelWidth = 60
741 local raidFrame = CreateFrame('FRAME', 'ChoirRaidFrame', rootFrame)
742 raidFrame:SetSize(labelWidth + (padding + buttonWidth) * maxPartySize,
743 (padding + buttonHeight) * (maxSubgroupQuantity + 1))
744 raidFrame:SetPoint('TOPLEFT', 0, -144)
745
746 --[[ TODO Add any debuff indicator ]]--
747 local j = 0
748 while (j < maxSubgroupQuantity) do
749 j = j + 1
750 local groupFrame = createRaidGroupFrame(raidFrame, j)
751 groupFrame:SetPoint('BOTTOMLEFT', 0, (j - 1) * (buttonHeight + padding))
752 end
753
754 --[[ NOTE Appearance of the party frame is conditional, only shown outside of raid.
755 -- Therefore corner case code is implemented. ]]--
756 local partyUnitSet = {'player', 'party1', 'party2', 'party3', 'party4'}
757 local playerPartyFrame = createRaidGroupFrame(raidFrame, maxSubgroupQuantity + 1, partyUnitSet)
758 playerPartyFrame:SetPoint('BOTTOMLEFT', 0, (maxSubgroupQuantity + 1) * (buttonHeight + padding))
759 playerPartyFrame:SetScript('OnEvent', partyFrameEventProcessor)
760
761 --[[ WARNING For some bizzare reason, possibly related to concurrency,
762 -- the raid toggling initialization __must__ be called here,
763 -- and not from another function for modularization.
764 -- This is probably an indication of a larger problem and
765 -- the lack of understanding of how exactly secure handlers work.
766 -- However, this approach does solve the problem that caused
767 -- the frames to behave unexpectedly and even crash the client.
768 ]]--
730 769 --[[ Given any spoiler is shown, then hide the raid frame. ]]-- --[[ Given any spoiler is shown, then hide the raid frame. ]]--
731 770 --[[ Given all spoilers are hidden, show the raid frame. ]]-- --[[ Given all spoilers are hidden, show the raid frame. ]]--
732 771 local spoilerList = {spoilerHolder:GetChildren()} local spoilerList = {spoilerHolder:GetChildren()}
 
... ... local function createRaidFrameToggleHandler(raidFrame, spoilerHolder)
763 802 end end
764 803 ]=]) ]=])
765 804 end end
766 end
767
768 local function createRaidFrame(rootFrame, spoilerHolder)
769 assert (rootFrame ~= nil)
770 assert (spoilerHolder ~= nil)
771
772 local maxPartySize = 5
773 local maxSubgroupQuantity = 8
774
775 local buttonWidth = 48
776 local buttonHeight = 24 + 12 + 8
777 local padding = 2
778
779 local labelWidth = 60
780 local raidFrame = CreateFrame('FRAME', 'ChoirRaidFrame', rootFrame)
781 raidFrame:SetSize(labelWidth + (padding + buttonWidth) * maxPartySize,
782 (padding + buttonHeight) * (maxSubgroupQuantity + 1))
783 raidFrame:SetPoint('TOPLEFT', 0, -144)
784
785 --[[ TODO Add any debuff indicator ]]--
786 local j = 0
787 while (j < maxSubgroupQuantity) do
788 j = j + 1
789 local groupFrame = createRaidGroupFrame(raidFrame, j)
790 groupFrame:SetPoint('BOTTOMLEFT', 0, (j - 1) * (buttonHeight + padding))
791 end
792
793 --[[ NOTE Appearance of the party frame is conditional, only shown outside of raid.
794 -- Therefore corner case code is implemented. ]]--
795 local partyUnitSet = {'player', 'party1', 'party2', 'party3', 'party4'}
796 local playerPartyFrame = createRaidGroupFrame(raidFrame, maxSubgroupQuantity + 1, partyUnitSet)
797 playerPartyFrame:SetPoint('BOTTOMLEFT', 0, (maxSubgroupQuantity + 1) * (buttonHeight + padding))
798 playerPartyFrame:SetScript('OnEvent', partyFrameEventProcessor)
799
800 createRaidFrameToggleHandler(rootFrame, spoilerHolder)
801 805
802 806 return raidFrame return raidFrame
803 807 end end
Hints:
Before first commit, do not forget to setup your git environment:
git config --global user.name "your_name_here"
git config --global user.email "your@email_here"

Clone this repository using HTTP(S):
git clone https://rocketgit.com/user/vrtc/wowaddons

Clone this repository using ssh (do not forget to upload a key first):
git clone ssh://rocketgit@ssh.rocketgit.com/user/vrtc/wowaddons

Clone this repository using git:
git clone git://git.rocketgit.com/user/vrtc/wowaddons

You are allowed to anonymously push to this repository.
This means that your pushed commits will automatically be transformed into a merge request:
... clone the repository ...
... make some changes and some commits ...
git push origin main